Skip to content

Update events polyfill for node 10#18

Open
SamBroner wants to merge 1 commit into
ionic-team:masterfrom
SamBroner:events-add-off
Open

Update events polyfill for node 10#18
SamBroner wants to merge 1 commit into
ionic-team:masterfrom
SamBroner:events-add-off

Conversation

@SamBroner

@SamBroner SamBroner commented Nov 27, 2020

Copy link
Copy Markdown

Based on this issue #8

I noticed that I have 3 additional files created during build. In this repository do you expect those to be checked in?

Possibly @manucorporat

@SamBroner

Copy link
Copy Markdown
Author

Just because I noticed @manucorporat hasn't been active on the other open PRs, possibly @mlynch or @dwieeb? No rush! Happy holidays.

@3zzy

3zzy commented Dec 17, 2020

Copy link
Copy Markdown

Hoping this gets merged soon cause I'm having the same issue:

(!) Missing shims for Node.js built-ins
Creating a browser bundle that depends on 'events'. You might need to include https://github.com/ionic-team/rollup-plugin-node-polyfills

@SamBroner

Copy link
Copy Markdown
Author

@FredKSchott, may be relevant for @snowpackjs?

@FredKSchott

FredKSchott commented Dec 18, 2020

Copy link
Copy Markdown

@SamBroner we're going to go ahead and fork this repo, with plans to eventually bring under the official Rollup org. See rollup/plugins#51 (comment)

Would love if you could create this PR onto our repo: https://github.com/snowpackjs/rollup-plugin-node-polyfills

@SamBroner

Copy link
Copy Markdown
Author

Snowpack repo moved to https://github.com/snowpackjs/rollup-plugin-polyfill-node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants