Repository navigation
Use non-Ansible config deployment in 'netlab config' - #3947
Merged
Merged
Conversation
The 'netlab config' command used Ansible playbook to deploy custom config templates regardless of the device 'netlab_config_mode'. This commit honors the 'netlab_config_mode' settings (where possible) in the 'netlab config' deployment: * The set_custom_config function has been augmented to recreate the data structures needed for non-ansible deployments * The Ansible config deployment was moved into a separate function (config_ansible_playbook) * The 'deploy_custom_config' code mirrors the 'netlab initial' deploy code. Internal methods are tried first, and if there are any nodes left, the Ansible playbook is called. Caveat: This approach cannot be used for containers with 'sh' config mode, as we cannot (easily) map new files into containers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'netlab config' command used Ansible playbook to deploy custom config templates regardless of the device 'netlab_config_mode'.
This commit honors the 'netlab_config_mode' settings (where possible) in the 'netlab config' deployment:
Caveat: This approach cannot be used for containers with 'sh' config mode, as we cannot (easily) map new files into containers.