Skip to content

Commit d8f0eb3

Browse files
d-w-moorealanking
authored andcommitted
[#3] changes for testing client with 4.3.0 vsn of iRODS
including: - create "server_python_version" variable - distinguish "client_python_version" - fix Python REP installer
1 parent bfbc25b commit d8f0eb3

4 files changed

Lines changed: 21 additions & 7 deletions

File tree

docker-compose.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ services:
1414
build:
1515
context: docker_build
1616
dockerfile: Dockerfile.provider
17+
args:
18+
server_py: "${server_python_version}"
1719
volumes:
1820
- "${irods_pkg_dir}:/irods_packages:ro"
1921
- ./irods_shared:/irods_shared:rw
@@ -35,6 +37,6 @@ services:
3537
dockerfile: Dockerfile.prc_test.${client_os_generic}
3638
args:
3739
os_image: "$client_os_image"
38-
py_N: "$python_version"
40+
py_N: "$client_python_version"
3941
depends_on:
4042
- irods-provider

docker_build/Dockerfile.provider

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
11
FROM ubuntu:18.04
22

33
ARG irods_pkg_dir
4+
ARG server_py=${server_python_version}
5+
ENV SERVER_PY "${server_py}"
46

57
RUN apt update
6-
RUN apt install -y wget sudo lsb-release apt-transport-https gnupg2 postgresql-client
8+
RUN apt install -y wget sudo lsb-release apt-transport-https gnupg2 postgresql-client python3
79
RUN wget -qO - https://packages.irods.org/irods-signing-key.asc | sudo apt-key add -
810
RUN echo "deb [arch=amd64] https://packages.irods.org/apt/ $(lsb_release -sc) main" | sudo tee /etc/apt/sources.list.d/renci-irods.list
911
RUN apt update
@@ -16,7 +18,7 @@ RUN chmod 600 root/.pgpass
1618

1719
RUN apt install -y rsyslog gawk
1820
RUN apt install -y jq
19-
ADD build_deps_list wait_on_condition send_oneshot setup_python_rule_engine /tmp/
21+
ADD build_deps_list wait_on_condition send_oneshot install_python_rule_engine setup_python_rule_engine /tmp/
2022

2123
# At Runtime: 1. Install apt dependencies for the iRODS package files given.
2224
# 2. Install the package files.
@@ -30,10 +32,11 @@ ADD build_deps_list wait_on_condition send_oneshot setup_python_rule_engine /tmp
3032
CMD apt install -y $(/tmp/build_deps_list /irods_packages/irods*{serv,dev,icommand,runtime,database-*postgres}*.deb) && \
3133
dpkg -i /irods_packages/irods*{serv,dev,icommand,runtime,database-*postgres}*.deb && \
3234
/tmp/wait_on_condition -i 5 -n 12 "psql -h icat -U postgres -c '\\l' >/dev/null" && \
33-
psql -h icat -U postgres -f /tmp/ICAT.sql && \
35+
psql -h icat -U postgres -f /tmp/ICAT.sql && \
3436
sed 's/localhost/icat/' < /var/lib/irods/packaging/localhost_setup_postgres.input \
35-
| python /var/lib/irods/scripts/setup_irods.py && \
36-
{ [ "${PYTHON_RULE_ENGINE_INSTALLED}" = '' ] || { apt install -y irods-rule-engine-plugin-python && /tmp/setup_python_rule_engine; } } && \
37+
| python${SERVER_PY} /var/lib/irods/scripts/setup_irods.py && \
38+
{ [ "${PYTHON_RULE_ENGINE_INSTALLED}" = '' ] || { /tmp/install_python_rule_engine "$PYTHON_RULE_ENGINE_INSTALLED" /irods_packages \
39+
&& /tmp/setup_python_rule_engine; } } && \
3740
{ pgrep -u irods irodsServer >/dev/null || su irods -c '~/irodsctl start'; \
3841
env PORT=8888 /tmp/send_oneshot "iRODS is running..." & } && \
3942
{ [ ! -d /irods_shared ] || { mkdir -p /irods_shared/reg_resc && mkdir -p /irods_shared/tmp && \
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
#!/bin/bash
2+
# usage $0 [""|"y"|"/"*] [container_irods_packages_path]
3+
if [[ $1 = /* ]]; then
4+
apt install -y "$2"/irods*rule*python*.deb
5+
elif [ "$1" != "" ]; then
6+
apt install -y irods-rule.\*python
7+
else
8+
: # nop
9+
fi

irods_consortium_continuous_integration_test_module.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ def run (CI):
66
final_config = CI.store_config(
77
{
88
"yaml_substitutions": { # -> written to ".env"
9-
"python_version" : "3",
9+
"client_python_version" : "3",
1010
"client_os_generic": "ubuntu",
1111
"client_os_image": "ubuntu:18.04",
1212
"python_rule_engine_installed": "y"

0 commit comments

Comments
 (0)