Skip to content

Add DPSERVICE_VERSION build arg to override version during Docker build #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
byteocean merged 1 commit into from
Apr 13, 2026
Merged

Add DPSERVICE_VERSION build arg to override version during Docker build #774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ ARG DPDK_VER=25.11
ARG DPDK_BUILDTYPE=release
ARG DPSERVICE_BUILDTYPE=debug
ARG DPSERVICE_FEATURES=""
ARG DPSERVICE_VERSION=""

WORKDIR /workspace

Expand Down Expand Up @@ -99,7 +100,7 @@ COPY include/ include/
COPY .git/ .git/

# Compile dpservice itself
RUN meson setup build -Dbuild_dpservice_cli=true -Dbuildtype=$DPSERVICE_BUILDTYPE $DPSERVICE_FEATURES && ninja -C build
RUN DPSERVICE_VERSION="${DPSERVICE_VERSION}" meson setup build -Dbuild_dpservice_cli=true -Dbuildtype=$DPSERVICE_BUILDTYPE $DPSERVICE_FEATURES && ninja -C build


# Extended build image for test-image
Expand Down
6 changes: 6 additions & 0 deletions hack/get_version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
#!/bin/bash

# Allow overriding the version via environment variable
if [ -n "$DPSERVICE_VERSION" ]; then
echo "$DPSERVICE_VERSION"
exit 0
fi

# For non-tagged commits, this is a simple "vX.X.X-XX-gXXXXXXX"
# For dpservice-bin tagged commits, this is "vX.X.X"
# For dpservice-go tagged commits, this is "go/dpservice-go/vX.X.X-XX-gXXXXXXX"
Expand Down
Loading