Fix missing flow_ptr init for ARP node#785
Open
PlagueCZ wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If ARP packet is encountered by CLS node, the graph will send the packet over to ARP node. That node then sends all proper packets to Tx node.
However as seen in tx_node.c:92, Tx node requires
df->conntrackto be initialized.Since
dp_init_flow_ptr()had not yet been called, the pointerdf->conntrackvalue is whatever was in the private packet area. And because packets come from a pool where packets get recycled, this can contain some valid memory from previous packets.This can be a big source of strange memory corruption.
Connected to issue #784