Wait for workers before cleaning up#787
Open
PlagueCZ wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During heavy packet processing, if dpservice is being stopped, it is possible for the main thread to start cleaning up before workers are done with the last packet (before checking
force_quit). In this case the code could touch some memory that is already freed.I guess this is rare and really an edge case, but this is the right pattern when working with worker threads.
Only downside I can see is that
rte_eal_mp_wait_lcore()could block forever. But we are running as a pod, so kubernetes will simply SIGKILL after 30s anyway. Which is not ideal, but again, this seems like a rare case.Discovered during testing #784