e2e-tests (4/4): Add e2e testdata fixtures for all resources types#410
Draft
nikatza wants to merge 4 commits into
Draft
e2e-tests (4/4): Add e2e testdata fixtures for all resources types#410nikatza wants to merge 4 commits into
nikatza wants to merge 4 commits into
Conversation
envtest mode for fast in-process e2e testingenvtest mode for fast in-process e2e testing
envtest mode for fast in-process e2e testing343add4 to
44ae09a
Compare
823e208 to
f735c68
Compare
5e9891b to
864aebb
Compare
51d400f to
ace1a56
Compare
864aebb to
b97c1c6
Compare
Add txtar-format test fixtures for all supported resource types. Signed-off-by: Pujol <enric.pujol@sap.com>
Commands executed via exec.CommandContext with CombinedOutput can hang when stdin is not explicitly set to nil. This was causing UndeployManager to block indefinitely during test cleanup. Changes: - Set cmd.Stdin = nil on all exec.Command calls to prevent stdin inheritance - Change UndeployManager to use kubectl delete -k directly instead of make undeploy to avoid shell pipeline stdin issues Signed-off-by: Pujol <enric.pujol@sap.com>
Documents the e2e test infrastructure including: - Envtest vs Cluster mode comparison - Test commands and environment variables - Testdata format and test flow - Architecture and gnmi-test-server behavior Signed-off-by: Pujol <enric.pujol@sap.com>
- test-e2e-envtest.yml: Fast in-process tests, no cluster required - test-e2e-cluster.yml: Full cluster tests with Kind, 8 parallel processes Signed-off-by: Pujol <enric.pujol@sap.com>
b97c1c6 to
37fea8a
Compare
ace1a56 to
bce5bb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds testdata fixtures for all 23 resource types, enabling comprehensive e2e testing of the network operator. Each test validates that the operator correctly translates Kubernetes resources into the appropriate device configuration via gNMI.
What's New
NX-OS Resource Tests (21 tests)
Each test is a separate txtar file:
Basic Configuration Resources:
banner.txt- System banner messagesdns.txt- DNS server configurationntp.txt- NTP server and authenticationlldp.txt- Link Layer Discovery Protocolsnmp.txt- SNMP server and community configurationsyslog.txt- Syslog server configurationNetwork Resources:
vrf.txt- Virtual Routing and Forwarding instancesroutedvlan.txt- L3 VLAN interfacessubinterface.txt- 802.1Q subinterfacesRouting Resources:
routingpolicy_prefixset.txt- Route filtering and policybgp_bgppeer.txt- Border Gateway Protocolospf.txt- Open Shortest Path Firstpim.txt- Protocol Independent Multicastisis.txt- Intermediate System to Intermediate SystemEVPN/VXLAN Resources:
nve.txt- Network Virtualization Edge (VXLAN)evpninstance.txt- EVPN instance configurationvpcdomain.txt- Virtual Port Channel domainSecurity & Services:
acl.txt- ACL rules and entriesdhcprelay.txt- DHCP relay configurationmanagementaccess.txt- Management interface ACLsOpenConfig Provider Test (1 test)
interface.txt- Demonstrates multi-provider support using OpenConfig modelsTest Format
All tests use the txtar format. Each
.txtfile contains: