Skip to content

Fix the Ampcor issues from Lijun's branch#282

Open
xhuang-jpl wants to merge 37 commits into
isce-framework:developfrom
xhuang-jpl:fix_ampcor_issue1
Open

Fix the Ampcor issues from Lijun's branch#282
xhuang-jpl wants to merge 37 commits into
isce-framework:developfrom
xhuang-jpl:fix_ampcor_issue1

Conversation

@xhuang-jpl
Copy link
Copy Markdown
Contributor

@xhuang-jpl xhuang-jpl commented Jun 1, 2026

This PR is to fix the Ampcor issue

  1. secondary window end pixel out of range in the across direction, at window (0, 686), pixel 27632 when the 20+5 data over Chile is processed. The runconfig of the dense_offset is
window_range: 64
window_azimuth: 128
half_search_range: 32
half_search_azimuth: 64
skip_range: 40
skip_azimuth: 75
correlation_surface_oversampling_factor: 16
deramping_method: complex
  1. The unexpected results for different search windows.

Xiaodong Huang added 30 commits September 19, 2023 20:40
@xhuang-jpl xhuang-jpl requested a review from hfattahi June 1, 2026 18:19
@xhuang-jpl xhuang-jpl added this to the R05.02.0 milestone Jun 1, 2026
@hfattahi hfattahi removed this from the R05.02.0 milestone Jun 2, 2026
@xhuang-jpl xhuang-jpl changed the title Fix the Ampcor issue that secondary window end pixel out of range in the range direction Fix the Ampcor issues from Lijun's branch Jun 4, 2026
@xhuang-jpl
Copy link
Copy Markdown
Contributor Author

@lijun99 Thanks again for your PR, would you mind taking a look the merge? It seems that I cannot add you to be the reviewer.

@lijun99
Copy link
Copy Markdown
Contributor

lijun99 commented Jun 4, 2026

I tested the merged version and it works fine. Thanks @xhuang-jpl !

@xhuang-jpl
Copy link
Copy Markdown
Contributor Author

I tested the merged version and it works fine. Thanks @xhuang-jpl !

Thanks @lijun99 , I also tested, and works fine on both CPU and GPU.

@xhuang-jpl xhuang-jpl requested a review from bhawkins June 5, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants