Skip to content

Use function call in Example of C.48: Prefer default member initializer #2330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
N-Dekker wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use function call in Example of C.48: Prefer default member initializer #2330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CppCoreGuidelines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5987,7 +5987,7 @@ How would a maintainer know whether `j` was deliberately uninitialized (probably
class X2 {
int i {666};
string s {"qqq"};
int j {0};
int j {numeric_limits<int>::min()};
public:
X2() = default; // all members are initialized to their defaults
X2(int ii) :i{ii} {} // s and j initialized to their defaults
Expand All @@ -6001,7 +6001,7 @@ How would a maintainer know whether `j` was deliberately uninitialized (probably
string s;
int j;
public:
X3(int ii = 666, const string& ss = "qqq", int jj = 0)
X3(int ii = 666, const string& ss = "qqq", int jj = numeric_limits<int>::min())
:i{ii}, s{ss}, j{jj} { } // all members are initialized to their defaults
// ...
};
Expand Down