fix: combine upstream fixes for scale-down and scale-up lambdas#2
Merged
Merged
Conversation
- Prevent EC2 termination when GitHub runner de-registration fails (upstream PR github-aws-runners#5061) - Prevent negative TotalTargetCapacity when runners exceed maximum (upstream PR github-aws-runners#5062) Changes: - scale-down.ts: Extract deleteGitHubRunner() helper, only terminate EC2 if all de-registrations succeed - scale-up.ts: Add Math.max(0, ...) guard to prevent negative runner count
shivdesh
force-pushed
the
fix/upstream-combined-fixes
branch
from
7a368bc to
0bea361
Compare
brilong
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR combines two upstream fixes from github-aws-runners/terraform-aws-github-runner:
Fix 1: Prevent EC2 termination when GitHub runner de-registration fails
Fix 2: Prevent negative TotalTargetCapacity when runners exceed maximum
Changes
Testing