test: assert DI extension wiring and provider key normalization invariant#45
Merged
Merged
Conversation
…iant Mutation testing showed the extension's container wiring was executed but never verified: every replaceArgument() call could be removed, the cacheItemPool reference dropped, and the provider options array_map unwrapped without a failing test. The documented invariant that provider keys are not normalized (my-provider != my_provider) was also untested. Kills all 20 mutants in src/DependencyInjection (was 12/20). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #45 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 62 62
===========================================
Files 9 9
Lines 282 282
===========================================
Hits 282 282
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First of four scoped follow-ups to #44 killing surviving mutants to push the mutation score above 90%. This PR covers
src/DependencyInjection(8 escaped mutants — the largest single cluster).Features Added
ItkDevOpenIdConnectExtensionTest: two new tests asserting the container wiring the extension performs — thecacheItemPoolReference on the provider manager config, the provider options mapping (keyed by provider name,optionslevel stripped), and the$cache/$cliLoginRoutearguments onCliLoginHelper,UserLoginCommandandCliLoginTokenAuthenticator. Previously onlyhasDefinition()was checked, so everyreplaceArgument()call could be deleted without a failing test.ConfigurationTest: test for the documented invariant that provider keys are not normalized (my-providerandmy_providerare distinct providers) —normalizeKeys(false)could be flipped totrueundetected.Files Changed
tests/DependencyInjection/ItkDevOpenIdConnectExtensionTest.php- wiring assertionstests/DependencyInjection/ConfigurationTest.php- key normalization testCHANGELOG.md- Unreleased bulletTest Plan
vendor/bin/phpunit— 82 tests, 182 assertions, greenvendor/bin/infection --filter=src/DependencyInjection— 20/20 mutants killed (was 12/20)🤖 Generated with Claude Code