test: assert container extension is created and memoized#46
Merged
Conversation
Mutation testing showed all five mutants of the getContainerExtension() condition survived: the extension type was never asserted and repeated calls recreating the extension went unnoticed. One test asserting the concrete type and instance identity on a second call kills all five. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #46 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 62 62
===========================================
Files 9 9
Lines 282 282
===========================================
Hits 282 282
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…le-extension # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second of four scoped follow-ups to #44 killing surviving mutants to push the mutation score above 90%. This PR covers
src/ItkDevOpenIdConnectBundle.php(5 escaped mutants).Features Added
testGetContainerExtension: assertsgetContainerExtension()returns anItkDevOpenIdConnectExtensionand that a second call returns the same instance. The memoization condition (null === $this->extension || false === $this->extension) previously had zero assertions against it, so all five of its mutants (operator flips, negations,||→&&) survived.Files Changed
tests/ItkDevOpenIdConnectBundleTest.php- new memoization testCHANGELOG.md- Unreleased bulletTest Plan
vendor/bin/phpunit— 80 tests, 169 assertions, greenvendor/bin/infection --filter=src/ItkDevOpenIdConnectBundle.php— 5/5 mutants killed (was 0/5)🤖 Generated with Claude Code