Skip to content

test: use RFC 2606 reserved domains in fixtures and README example#53

Merged
turegjorup merged 1 commit into
developfrom
test/rfc2606-fixture-domains
Jun 11, 2026
Merged

test: use RFC 2606 reserved domains in fixtures and README example#53
turegjorup merged 1 commit into
developfrom
test/rfc2606-fixture-domains

Conversation

@turegjorup

Copy link
Copy Markdown
Collaborator

Summary

Mirrors itk-dev/openid-connect-bundle#49: replaces invented domains in test fixtures and the README usage example with RFC 2606 reserved names — provider.example.org for IdP-side URLs (metadata, 28×) and app.example.org for application-side URLs (redirect URI, 2×).

Files Changed

  • tests/Security/OpenIdConfigurationProviderTest.php - some.urlprovider.example.org, redirect.urlapp.example.org
  • README.md - usage example redirectUri
  • CHANGELOG.md - Unreleased bullet

Test Plan

  • vendor/bin/phpunit — 103 tests, 192 assertions, green
  • PHPStan max level + markdownlint — clean
  • grep -rn 'some\.url|redirect\.url' tests/ src/ README.md — no matches

Notes

  • https://logout.test already uses the RFC 2606-reserved .test TLD — left as is
  • The azure_b2c_test.b2clogin.com fixture endpoints are a fake subdomain of Microsoft's real b2clogin.com — left as realistic Azure B2C shape examples (this library documents itself as made/tested for Azure AD B2C); happy to sweep those to provider.example.org too if preferred

🤖 Generated with Claude Code

provider.example.org for IdP-side URLs (metadata), app.example.org for
application-side URLs (redirect URI); some.url and redirect.url are
not reserved names. The post-logout URL already uses the reserved
.test TLD and the Azure B2C fixture endpoints are left as realistic
shape examples.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@codecov

codecov Bot commented Jun 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d3b8c2b) to head (843d003).

Additional details and impacted files
@@             Coverage Diff             @@
##             develop       #53   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        71        71           
===========================================
  Files              1         1           
  Lines            185       185           
===========================================
  Hits             185       185           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@turegjorup turegjorup merged commit 9fedae3 into develop Jun 11, 2026
17 checks passed
@turegjorup turegjorup deleted the test/rfc2606-fixture-domains branch June 11, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant