test: use RFC 2606 reserved domains in fixtures and README example#53
Merged
Conversation
provider.example.org for IdP-side URLs (metadata), app.example.org for application-side URLs (redirect URI); some.url and redirect.url are not reserved names. The post-logout URL already uses the reserved .test TLD and the Azure B2C fixture endpoints are left as realistic shape examples. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #53 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 71 71
===========================================
Files 1 1
Lines 185 185
===========================================
Hits 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors itk-dev/openid-connect-bundle#49: replaces invented domains in test fixtures and the README usage example with RFC 2606 reserved names —
provider.example.orgfor IdP-side URLs (metadata, 28×) andapp.example.orgfor application-side URLs (redirect URI, 2×).Files Changed
tests/Security/OpenIdConfigurationProviderTest.php-some.url→provider.example.org,redirect.url→app.example.orgREADME.md- usage exampleredirectUriCHANGELOG.md- Unreleased bulletTest Plan
vendor/bin/phpunit— 103 tests, 192 assertions, greengrep -rn 'some\.url|redirect\.url' tests/ src/ README.md— no matchesNotes
https://logout.testalready uses the RFC 2606-reserved.testTLD — left as isazure_b2c_test.b2clogin.comfixture endpoints are a fake subdomain of Microsoft's realb2clogin.com— left as realistic Azure B2C shape examples (this library documents itself as made/tested for Azure AD B2C); happy to sweep those toprovider.example.orgtoo if preferred🤖 Generated with Claude Code