fix(hook): stop singling out proposal accept/reject/drain in prompt note#77
Open
itlackey wants to merge 1 commit into
Open
fix(hook): stop singling out proposal accept/reject/drain in prompt note#77itlackey wants to merge 1 commit into
itlackey wants to merge 1 commit into
Conversation
The user-prompt-expansion hook special-cased /akm-proposal accept|reject|drain (and bare 'proposal drain') with a proposal-specific 'confirm before mutating' note. That guard was the last remnant of the proposal-approval gating; the hard PreToolUse block was already removed. Proposal commands now get the same generic /akm- slash-command note as everything else; the memory-promote/reject note is unchanged (message tightened to 'mutating memory flows'). Updated the four affected user-prompt-expansion tests to match (memory note text; proposal reject/drain now assert the generic guidance). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Eval diff
Metric deltas
Plugin surfaceNo surface changes. No regressions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
user-prompt-expansionhook special-cased/akm-proposal accept|reject|drain(and bareproposal drain) with a proposal-specific "confirm before mutating" note. This removes that special case — proposal commands now get the same generic/akm-slash-command note as every other command. Theakm-memory-promote|rejectnote is unchanged (message tightened to "mutating memory flows").Why
It was the last remnant of the proposal-approval gating. The hard
PreToolUseblock onakm proposal accept|rejectwas already removed upstream; this note was the only proposal-specific guard left, and it added friction to authorized proposal review without being an actual stop.Tests
Updated the four affected
user-prompt-expansiontests to match the new behavior (memory note text;akm-proposal reject/drainnow assert the generic guidance andnot.toContainthe memory note). Full suite green locally:No version bump — leaving that to the release workflow.
🤖 Generated with Claude Code