Fix missing high nibble in POM CV bit-write data byte#10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a frame-encoding bug in the POM bit-write commands:
DB5was built as(V?0x08:0) | PPP, omitting the high nibble.DB5is the DCC bit-manipulation data byte, which NMRA S-9.2.1 defines as111K-DBBB. For a writeK=1, so the high nibble must be1111(0xF0). Without it the decoder receives an invalid opcode and silently ignores the frame — so a raw bit write does nothing on hardware.Fixed (same defect in both)
CvPomWriteBitCommand(§6.7, locomotive) — also corrects the frame emitted by the safeWritePomCvBitAsyncwrapper.CvPomAccessoryWriteBitCommand(§6.10, accessory) — identical bug.DB5is now0xF0 | (V?0x08:0) | (PPP & 0x07).Tests
Updated both byte-exact test fixtures (
DB5and recomputed XOR). The byte read/write and bit read paths were already correct and are unaffected. Full solution green: 710 passed.