Safe POM CV bit read/write#9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds safe (retrying, deadline-bounded) read/write for a single CV bit on the main track (POM), building on the safe CV programming merged in #8.
New API on
IZ21CommandStationWritePomCvBitAsync(loco, cv, bitPosition, bitValue, timeout)— writes one CV bit (LAN_X_CV_POM_WRITE_BIT, §6.7). Since a POM write returns no acknowledgement, it verifies by reading the CV byte back (LAN_X_CV_POM_READ_BYTE, §6.8, RailCom) and retrying until the target bit matches or the deadline elapses.ReadPomCvBitAsync(loco, cv, bitPosition, timeout) → bool— reads the CV byte back and returns the target bit.Notes
_cvLockserialization,Task.WaitAsyncdeadline bounding, OCE→timeout mapping, dispose handling,CvRetryDelaybackoff, and short-circuit abort.bitPositionis validated to0–7(ArgumentOutOfRangeExceptionotherwise).Tests
8 new unit tests (write-bit match / retry / timeout / invalid position; read-bit set / clear / timeout / invalid position). Full solution green: 710 passed, hardware smoke tests skipped.