fix: split Windows manifest cleanup out of the Studio branch#1052
Draft
XucroYuri wants to merge 1 commit intojackwener:mainfrom
Draft
fix: split Windows manifest cleanup out of the Studio branch#1052XucroYuri wants to merge 1 commit intojackwener:mainfrom
XucroYuri wants to merge 1 commit intojackwener:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am working toward a larger Studio contribution, but before sending the frontend itself upstream I wanted to peel off one small fix that kept muddying the branch on Windows.
While regenerating the manifest and running the plugin discovery tests locally, I kept hitting two problems:
build-manifestcould write Windows path separators back intocli-manifest.json, which made the file look changed even when the actual command inventory had not meaningfully changed.So this PR is intentionally small.
It does four things:
sourceFilepaths before writing the manifestcli-manifest.jsonnewline-stableI ran:
npx vitest run src/build-manifest.test.ts src/engine.test.ts src/cli.test.ts src/diagnostic.test.ts --project unitnpm run typecheckThe bigger thing I am preparing is Studio itself: a frontend workspace for command discovery, readiness checks, execution, and troubleshooting on top of the existing OpenCLI runtime. I left all of that out of this PR on purpose so this patch can stand on its own and be reviewed quickly.