Skip to content

Add options for request through ssl#64

Open
rado-h wants to merge 8 commits into
jadell:masterfrom
rado-h:master
Open

Add options for request through ssl#64
rado-h wants to merge 8 commits into
jadell:masterfrom
rado-h:master

Conversation

@rado-h

@rado-h rado-h commented Sep 3, 2012

Copy link
Copy Markdown
Contributor

Add options to the transport for ssl request.
Example:
$transport = new Transport\Curl("127.0.0.1", "443");
$sslOptions = array(CURLOPT_SSL_VERIFYPEER => true, CURLOPT_SSLCERT => "/path/to/cert");
$transport->useHttps(true, $sslOptions);
OR
$transport = new Transport\Stream("127.0.0.1", 443);
$sslOptions = array("verify_peer" => false, "cafile" => "path/to/cafile);
$transport->useHttps(true, $sslOptions);

Also when sending request through ssl with context_stream the stream_options array must be with key http for the http options and the ssl specific option must be with key ssl.

@travisbot

Copy link
Copy Markdown

This pull request passes (merged ad6b9fb into 6577edb).

@rado-h

rado-h commented Oct 6, 2012

Copy link
Copy Markdown
Contributor Author

@jadell I added a simple DI class which may solve the problems with the configurations. The idea is to keep there configuration variables and things such as closures for creating nodes/relationships...etc. I also added a bootstrap file with some initial dependencies to be populated in the DI (Bootstrap.php). Putting more object initialization callbacks in the DI will also allow easier extension of the library.

@jadell

jadell commented Oct 7, 2012

Copy link
Copy Markdown
Owner

I like where this is going, but I'd like to make a few changes. It's similar to the "Configuration" class I was thinking of introducing. I'm going to merge this into a branch and tweak it a bit, if that's okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants