Update spec to reflect addition of Constraint and @Is#1159
Closed
gavinking wants to merge 3 commits into
Closed
Conversation
njr-11
reviewed
Jun 25, 2025
Member
njr-11
left a comment
njr-11
left a comment
There was a problem hiding this comment.
Good idea to add this to the spec as well. I added a few comments. The ordering change seemed very minor although I couldn't figure out the reason for it, and I listed a possible ordering that I thought might make sense, but feel free to ignore that if you did have reasons for the other ordering.
Co-authored-by: Nathan Rauh <nathan.rauh@us.ibm.com>
Member
Author
|
@njr-11 I've attempted to address your feedback. WDYT? |
gavinking
force-pushed
the
constraints-and-restrictions
branch
from
4890254 to
cec1f0d
Compare
gavinking
force-pushed
the
constraints-and-restrictions
branch
from
cec1f0d to
5cc0693
Compare
njr-11
changed the title
Contributor
|
@gavinking when you have time, could you rebase this one? |
Member
Author
|
Superseded by #1170. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.