Migrate from legacy to new React lifecycle

[rbardini]

React will soon deprecate componentWillMount, componentWillReceiveProps and componentWillUpdate methods due to their potential misuse, especially once async rendering is launched. In fact, enabling strict mode already warns about these unsafe lifecycle methods usage.

This PR moves module loading logic from componentWillMount to componentDidMount, which is the recommended upgrade path in this case.

[tajo]

Did you test this with regards of SSR (cWM is called but cDM not)?

[rbardini]

I assumed tests were already covering this. Are there any use cases missing in this regard?

[mr-pinzhang]

isn't this should be migrate to constructor as new lifecycle suggested?

[roccoluke]

Any timeframe as to when to expect this to me merged?

[amakhrov]

@tajo @jamiebuilds any feedback on that?

[titouancreach]

@bjminhuang I don't think so. If you do that, you'll potentially add a side effect (this.setState) in the constructor that is not recommended. The React way for doing this is componentDidMount

[the0neWhoKnocks]

Would really like to see this get merged. Currently trying to integrate this with a project on React 16.4 and the use of componentWillMount is causing the component not to render properly for SSR. I went in to the react-loadable module and swapped componentWillMount for componentDidMount and no more warnings or SSR issues.

[the0neWhoKnocks]

Actually, looks like this may have partially been addressed by this merged PR #123, although componentWillMount still remains along with the added componentDidMount.

[the0neWhoKnocks]

Any traction on this? The PR appears ready to merge.

[dbenchi]

Any news about this PR?

[mshwery]

LGTM! Anything I can do to help move this along?

[jaybe78]

@abenchi @mshwery
This includes your PR + migration to babel .7 and webpack 5
https://www.npmjs.com/package/jaybe-react-loadable
Cheers

[jedwards1211]

@jamiebuilds can we please get this merged? Do you need a new maintainer?

[courtyenn]

Would love to see this make some progress.

[jaybe78]

@abenchi yes you can lazy load with latest version of react, though suspense is not supported in SSR mode... So for people like me who server side render their app, there's no option beside react universal or react loadable

[owen2345]

Hey @jamiebuilds @tajo
any news to fix the concerning issue of this PR?

[slorber]

For anyone interested, here's my solution to get rid of the warning (React 16 + 17) and still get this working (client+SSR).

#213 (comment)