hal: add validation for UCI section types to support hyphens#265
Draft
rslater-cs wants to merge 4 commits into
Draft
hal: add validation for UCI section types to support hyphens#265rslater-cs wants to merge 4 commits into
rslater-cs wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Previously section names were given the same validation as uci identifiers, this was causing issues as section were using hypens in their names which is valid with uci usage but being flagged as invalid. I have made a seperate validation path for sections.
Manual test
Manual test description
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?