Leer accountsIdsByService del Parameter Store con fallback a Secrets Manager#16
Open
juanhapes wants to merge 2 commits into
Open
Leer accountsIdsByService del Parameter Store con fallback a Secrets Manager#16juanhapes wants to merge 2 commits into
juanhapes wants to merge 2 commits into
Conversation
added 2 commits
June 29, 2026 15:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
El
Invokerresolvía el account id de cada service (para invocar lambdas cross-account) leyendo el secretAccountsIdsByServicede Secrets Manager, replicado en ~60 cuentas. Esta PR pasa a leer el Parameter StoreaccountsIdsByService(único en la cuenta Devops, RAM-shared), armando el ARNarn:aws:ssm:${AWS_REGION}:${DEVOPS_ACCOUNT_ID}:parameter/accountsIdsByServicey resolviéndolo con una única llamadaGetParameter.Cambios
SecretFetcherpara leer el Parameter Store vía@aws-sdk/client-ssm. La interfaz pública (fetch()/secretValue) queda intacta.logger.warn) solo cuando faltaDEVOPS_ACCOUNT_ID— para services con el plugin viejo durante la transición. Si la env var está presente y elGetParameterfalla, no hay fallback (tiraJANIS_SECRET_MISSING, no enmascara errores reales).ssm:GetParameterainvokePermissionssobrearn:aws:ssm:*:*:parameter/accountsIdsByService.@aws-sdk/client-ssm.A tener en cuenta
DEVOPS_ACCOUNT_IDlo inyecta el pluginsls-helper-plugin-janis(ya disponible en el pipeline vía/shared/{env}/ci-cd). El fallback al secret mantiene el comportamiento actual mientras los services adoptan el plugin nuevo.