Gpl issues#41
Open
dangrie158 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #40
This removes the 2 tainted dependencies
convertdateandlunardateas they are GPL licensed or depend on GPL licensed code.lunardateis replaced by LunarCalendar which has the same functionality but does not depend on any GPL Code.convertdateis vendored with only the necessary functionality. the fullconvertdatelibrary depends on PyMeeus which is GPL v3, however this functionality is not used bycalendra. Sadly,convertdatemaintainers made it clear that they do not care about the violation thus I decided to make use of the MIT License of the code and vendor it into Calendra in this PR as I do not see another way.Let me know what you think of this approach