Fix health report rendering: tables, scrolling, emoji, wrapping - #21
Merged
Conversation
- Render markdown tables as formatted text with column alignment instead of raw markdown pipe syntax - Add word-wrapping in table cells so content is never truncated - Preserve short columns (<=12 chars) at natural width; only shrink wide columns proportionally when table exceeds available width - Add scroll loops to health state and run detail pages - Set UTF-8 output encoding for emoji characters - Add [M]arkdown toggle to view raw markdown for debugging render issues - Fix WrapMarkupLine failing on escaped brackets (e.g. [[#83775]]) by re-escaping literal bracket chars when rebuilding wrapped output - Pass ContentWidth to ToMarkupLines so tables are constrained at render time rather than relying on panel wrapping which breaks table structure - Disable truncation in health pages (use wrapping instead) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Health reports were rendering with several issues that made them hard to read in the terminal. This PR fixes all of them and adds a raw markdown toggle for debugging future rendering problems.
Problems fixed
ReadKeywithout a scroll loop. Now supports Up/Down/PgUp/PgDn navigation.Console.OutputEncoding = Encoding.UTF8.WrapMarkupLinedecoded escaped brackets ([[to[) for width measurement but failed to re-escape them when rebuilding wrapped output. Spectre then treated literal[#83775]as a (malformed) tag. Fixed withEscapeBrackets()helper.New feature
Key design decisions
maxWidthparameter threaded fromContentWidthintoToMarkupLinesandRenderTableAsTextso tables are constrained before panel rendering, avoiding the wrapping layer that can't understand table structureTesting