feat(bcquality): consumir el nuevo índice de conocimiento de BCQuality#82
Draft
javiarmesto wants to merge 1 commit into
Draft
feat(bcquality): consumir el nuevo índice de conocimiento de BCQuality#82javiarmesto wants to merge 1 commit into
javiarmesto wants to merge 1 commit into
Conversation
BCQuality added a knowledge index (knowledge-index.json) that its review skills read at the Source step instead of opening every knowledge file's frontmatter. The index is owned and produced by BCQuality (tools/Build-KnowledgeIndex.ps1); ALDC just runs that generator. The install scripts now build the index over the clone right after checkout. ALDC builds it once at install because it consumes the full clone (it filters by enabled-layers/disabled-skills in the task-context, it does not prune the clone by allow/deny policy), so the index is stable between installs; entry.md's preparation step rebuilds it on demand at runtime when absent or stale. Fully defensive and never fatal: a missing generator (older BCQuality), a missing pwsh, or a failed build all fall back to path-based discovery — review still works, just without the index acceleration. Source stays configurable (upstream microsoft/BCQuality by default), unchanged here. Documented in docs/bcquality.md and tools/bcquality/README.md; CHANGELOG updated. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013i5qwqRTzBPxHxYxUzFYmY
Contributor
📋 Collection Validation Results✅ Validation passed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
BCQuality ha añadido una nueva capacidad: un índice de conocimiento (
knowledge-index.json) que sus skills de review leen en el paso Source en lugar de abrir el frontmatter de cada fichero de conocimiento. Esta PR pone a ALDC a consumir esa capacidad.El índice es propiedad de BCQuality (lo genera su
tools/Build-KnowledgeIndex.ps1); ALDC no reimplementa el parser, solo ejecuta ese generador.Cambios
tools/bcquality/install.sh/install.ps1— tras el clon, construyenknowledge-index.jsonsobre el clon ejecutando el generador de BCQuality.docs/bcquality.md— nueva sección "Knowledge index (Source-step acceleration)".tools/bcquality/README.md— documentado el paso de build en el lifecycle de install.CHANGELOG.md— entrada en[Unreleased].Decisiones de diseño
enabled-layers/disabled-skills/pilotSkillsen el task-context. Por eso el índice = corpus completo y es estable entre installs, y construirlo una vez es lo idiomático (no exigepwshen el runtime del agente). El paso Preparation deentry.mdlo reconstruye en runtime si falta o está obsoleto — ambos caminos se refuerzan.pwshausente, o build fallido → todos caen a path-based discovery. El review sigue funcionando, solo pierde la aceleración. Mismo principio que el fallback de capa ausente: BCQuality es aditivo y nunca falla el review.external.bcquality.urlsigue en upstreammicrosoft/BCQuality(configurable). Esta PR no cambia la fuente.entry.mdposee el paso Preparation; al construirlo en install, el paso del agente lo encuentra presente y es un no-op. Se evita así tocar las múltiples copias de los agentes.Verificación
bash -n tools/bcquality/install.sh→ OK.install.ps1revisado manualmente (try/catch en lugar de$LASTEXITCODE, que no es fiable tras invocar un.ps1). No habíapwshen el entorno para parse-check automático — que es exactamente el caso que el fallback deinstall.shcubre.Note
A confirmar al clonar: si el upstream
microsoft/BCQualityaún no ha mergeadotools/Build-KnowledgeIndex.ps1, el paso de install se salta con un aviso (sin romper) hasta que la capacidad llegue upstream.🤖 Generated with Claude Code
Generated by Claude Code