#22 Allow horizontal and vertical padding to be set independently#23
Open
Tyler-Lopez wants to merge 1 commit into
Open
#22 Allow horizontal and vertical padding to be set independently#23Tyler-Lopez wants to merge 1 commit into
Tyler-Lopez wants to merge 1 commit into
Conversation
…dently ### Background The margin from the coachmark to its anchor and the screen edge is currently set by a single integer value. This failed my use-case of a TOP or BOTTOM coachmark that should be a certain distance horizontally from the screen-edge, but very close to its anchoring view. ### Changes This commit introduces two new `Builder` functions: `withPaddingHorizontal` and `withPaddingVertical`. The private parameter `padding` has been split into `paddingHorizontal` and `paddingVertical` and these functions set the respective value. The existing `Builder` function `withPadding` sets both `paddingHorizontal` and `paddingVertical` and is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The margin from the coachmark to its anchor and the screen edge is currently set by a single integer value. This failed my use-case of a TOP or BOTTOM coachmark that should be a certain distance horizontally from the screen-edge, but very close to its anchoring view.
Changes
This commit introduces two new
Builderfunctions:withPaddingHorizontalandwithPaddingVertical.The private parameter
paddinghas been split intopaddingHorizontalandpaddingVerticaland these functions set the respective value.The existing
BuilderfunctionwithPaddingsets bothpaddingHorizontalandpaddingVerticaland is unchanged.