Skip to content

fix crash on empty txt file #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kifio wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix crash on empty txt file #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53d3e4b
fix crash on empty txt file
Dec 29, 2025
927063c
Update Supported.swift
kifio Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/FileType/Supported.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1679,7 +1679,7 @@ public extension MimeType {
return bytes[0...2] == [0x49, 0x49, 0xBC]
}),
.init(mime: "image/webp", type: .webp, bytesCount: 4, matches: { bytes, _ in
return bytes[8...11] == [0x57, 0x45, 0x42, 0x50]
return bytes.count > 7 && bytes[8...11] == [0x57, 0x45, 0x42, 0x50]
}),
.init(mime: "image/x-adobe-dng", type: .dng, bytesCount: 4, matches: { bytes, _ in
// TODO: Implement magic number check for image/x-adobe-dng
Expand Down
5 changes: 5 additions & 0 deletions Tests/FileTypeTests/FileTypeTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,3 +129,8 @@ import Foundation
}
}

@Test func testBlankTxt() async throws {
let data = Data([0x33, 0x2E, 0x31, 0x30, 0x2E, 0x33, 0x0A]) // emty txt file bytes
#expect(FileType.mimeType(data: data) == nil)
}