fix: resolve path canonicalization issue in acceptFolder on macOS/Windows#107
Open
maxandersen wants to merge 1 commit into
Open
fix: resolve path canonicalization issue in acceptFolder on macOS/Windows#107maxandersen wants to merge 1 commit into
maxandersen wants to merge 1 commit into
Conversation
…dows On macOS, temp directories resolve through /private/var (e.g. /var/folders/... -> /private/var/folders/...) causing jdkFolder.startsWith(jdksRoot) to return false when the jdkFolder path has been resolved via toRealPath() but jdksRoot has not. This caused LinkedJdk.linked() to fall through to ExternalJdkProvider, producing external-<hash> ids instead of the correct provider id. The fix adds an isUnderRoot() helper that falls back to comparing real (canonical) paths when the simple startsWith check fails. The resolved real root path is cached for performance. Fixes jbangdev/jbang#2515 test failures on macOS and Windows.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, temp directories resolve through
/private/var(e.g./var/folders/...→/private/var/folders/...) causingjdkFolder.startsWith(jdksRoot)to returnfalsewhen thejdkFolderpath has been resolved viatoRealPath()butjdksRoothas not.This caused
LinkedJdk.linked()to fall through toExternalJdkProvider, producingexternal-<hash>ids instead of the correct provider id (e.g.17.0.7-jbang).Fix
Adds an
isUnderRoot()helper inBaseFoldersJdkProviderthat falls back to comparing real (canonical) paths when the simplestartsWithcheck fails. The resolved real root path is cached for performance.DefaultJdkProvider.acceptFolder()is updated to use the same helper.Related