fix: Use DomTrip for POM parsing#2526
Open
cstamas wants to merge 1 commit into
Open
Conversation
Use DomTrip, a modern (round-trip capable) library instead of legacy Maven model. Latter drags in a lot of legacy, and is not future proof, while DomTrip is (unless structure of POM changes so much that tags are not in place). Also, fix the logic, as if POM has parent, G and V may come from it. DomTrip is nice to have anyway, as it is not Maven specific (but has Maven supporting module) in a "swiss army knife" like project like JBang is.
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use DomTrip, a modern (round-trip capable) XML library instead of legacy Maven model. Latter drags in a lot of legacy, and is not future proof, while DomTrip is (unless structure of POM changes so much that tags are not in place). This also shaves off 500 KB of dependencies, as domptrip two modules are circa 500 KB less than maven-model + deps. Just stay away from legacy.
Also, fix the logic, as if POM has parent, G and V may come from it.
DomTrip is nice to have anyway, as it is not Maven specific (but has Maven supporting module) in a "swiss army knife" like project as JBang is.