fix: optimize test suite performance (2m42s → ~50s)#2527
Merged
Conversation
Two tests (testHelloWorldGAVWithNoMain, testHelloWorldGAVWithModulesButNoManifest) blocked for 30 seconds each waiting on Util.askInput() interactive timeout. Add Util.getAskInputTimeout()/setAskInputTimeout() following the existing static field pattern (setQuiet, setOffline, etc.) and set timeout to 0 in BaseTest.initEnv(). Reduces test suite from ~2m42s to ~1m45s (35% faster).
…loads The 6 sleep calls waited for filesystem timestamp granularity so cache-evict checks would see files as stale. Instead, backdate the cached file's last-modified time by 2 seconds using Files.setLastModifiedTime(). Reduces TestUtilDownloads from ~6.9s to ~0.6s.
Uncomment maxParallelForks = availableProcessors/2 in build.gradle. Each fork runs in a separate JVM with its own WireMock and mavenTempDir, so there are no concurrency issues. Reduces test suite wall time from ~1m40s to ~50s on a 14-core machine.
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Suite Performance Optimization
Three independent improvements that reduce the test suite wall time from 2m 42s to ~50s (3.2x faster).
Commits
fix: make askInput timeout configurable to avoid 60s test delay
testHelloWorldGAVWithNoMain,testHelloWorldGAVWithModulesButNoManifest) blocked 30s each waiting on interactiveUtil.askInput()timeoutUtil.getAskInputTimeout()/setAskInputTimeout()following existing static field patternBaseTest.initEnv()sets timeout to 0 so tests fail immediately instead of waitingtest: replace Thread.sleep(1100) with file backdating in TestUtilDownloads
Thread.sleep(1100)waited for filesystem timestamp granularity for cache-evict checksFiles.setLastModifiedTime()to backdate cached files by 2 secondsbuild: enable parallel test execution
maxParallelForks = availableProcessors/2inbuild.gradlemavenTempDir— no concurrency issuesResults