fix(openjdk): add temporary jdk 28 ea alias#470
Conversation
Greptile SummaryThis is a targeted data patch that inserts a
Confidence Score: 4/5Safe to merge as a temporary unblocker; the single changed file is data-only with a valid JSON structure and correct checksum reuse. The change is a single data row insertion with no logic changes. The main risk is that the public/api/jvm/ea/linux/x86_64.json — specifically the new alias row and whether downstream tooling validates the JDK version post-extraction. Important Files Changed
Reviews (1): Last reviewed commit: "fix(openjdk): add temporary jdk 28 ea al..." | Re-trigger Greptile |
| "version": "28.0.0-ea+1" | ||
| }, | ||
| { | ||
| "checksum": "sha256:d9b2b25f13a93424625f129bc9725ded401725e36ac819b9f4951f02bc8fc91c", | ||
| "created_at": "2026-06-10T20:37:19", | ||
| "features": [], | ||
| "file_type": "tar.gz", | ||
| "image_type": "jdk", | ||
| "java_version": "28.0.0-ea", | ||
| "jvm_impl": "hotspot", | ||
| "url": "https://download.java.net/java/early_access/jdk28/1/GPL/openjdk-28-ea+1_linux-x64_bin.tar.gz", | ||
| "vendor": "openjdk", |
There was a problem hiding this comment.
URL/version mismatch in alias entry
The new alias entry sets version and java_version to "28.0.0-ea" but its url points to openjdk-28-ea+1_linux-x64_bin.tar.gz — the same binary as the ea+1 row. If mise (or any downstream tooling) validates the installed JDK's reported version string against the requested java_version after extraction, it will see 28-ea+1 from the runtime and fail the match against 28.0.0-ea. This is presumably an accepted trade-off for the temporary unblock, but worth confirming that no such post-install version check is performed before superseding #469/#468.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR adds a new OpenJDK 28 early-access build entry for Linux x86_64 to the public API dataset, including checksum, ChangesOpenJDK 28 EA Dataset
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Comment |
Summary
openjdk-28.0.0-eaopenjdk-28.0.0-ea+1row intactWhy
The mise 2026.6.2 release e2e currently asks for
java[release_type=ea]@openjdk-28.0.0-ea, but the published metadata only resolvesopenjdk-28.0.0-ea+1. This tiny data-only PR is intended to unblock the release while the larger #469/#468 data repair sequence is reviewed.Notes
This does not repair the
features: [""]corruption from #467. It is intentionally a temporary unblocker and should be superseded by the clean revert/repair flow.Validation
jq empty public/api/jvm/ea/linux/x86_64.jsongit diff --checkThis PR was generated by an AI coding assistant.
Note
Low Risk
Data-only metadata addition with no runtime or security logic changes; duplicate row points at an already-published artifact.
Overview
Adds a temporary alias row in
public/api/jvm/ea/linux/x86_64.jsonsoopenjdk-28.0.0-earesolves on Linux x64. The new entry reuses the same checksum and download URL as the existing28.0.0-ea+1OpenJDK EA build; onlyversionandjava_versionare set to28.0.0-ea. The prior28.0.0-ea+1row is unchanged.Also fixes the file ending so the JSON array closes with a trailing newline.
Reviewed by Cursor Bugbot for commit 38ee633. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit