Skip to content

Fix numeric sorting in distribution table#542

Open
Ashuthosh0 wants to merge 1 commit into
jenkinsci:masterfrom
Ashuthosh0:fix/numeric-sort-in-distribution-table
Open

Fix numeric sorting in distribution table#542
Ashuthosh0 wants to merge 1 commit into
jenkinsci:masterfrom
Ashuthosh0:fix/numeric-sort-in-distribution-table

Conversation

@Ashuthosh0

Copy link
Copy Markdown

Fixes #414

Description

This PR fixes numeric sorting in the Distribution table.

before : sorted according to display text

1stTest__Bitbucket  1680	
2ndTestB            191456	
1stTest             51624	
2ndTestA            56220

after : sorted according to raw value

1stTest__Bitbucket  1680	
1stTest             51624	
2ndTestA            56220
2ndTestB            191456	

The fix adds a data-order attribute using the raw metric value in distribution.jelly, while keeping the displayed label unchanged.

Testing done

image

Ran mvn verify successfully.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sorting by size does alphabetical sort instead of sorting by the value

2 participants