revert: inline release_crate back to toolkit/release_crate#1005
Draft
gortavoher wants to merge 1 commit into
Draft
revert: inline release_crate back to toolkit/release_crate#1005gortavoher wants to merge 1 commit into
gortavoher wants to merge 1 commit into
Conversation
Now that toolkit#489 (release_crate update_pcu + pcu_verbosity) is merged, the temporary inline copy from #1004 is no longer needed. Restore the standard toolkit/release_crate invocations, passing the update_pcu pipeline parameter through (and to release_prlog), and drop the local copied job. GATED: cannot merge until the toolkit version containing #489 is released and pcu's orb pin is bumped off 6.4.2 (which has no release_crate.update_pcu). The pin is left at 6.4.2 only as a marker — bump it before un-drafting. Signed-off-by: Jeremiah Russell <jerry@jrussell.ie>
Contributor
✅ Commit Signature Verification - SuccessAll commits have been verified successfully. Summary
No impersonation attempts detected. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft — gated on the toolkit release + pin bump. Do not merge yet.
Retires the temporary inline
release_cratefrom #1004 now that toolkit#489 (release_crateupdate_pcu+pcu_verbosity) is merged.What it does
release_cratejob.toolkit/release_crate, passingupdate_pcu: << pipeline.parameters.update_pcu >>(and wiresupdate_pcutotoolkit/release_prlogtoo).update_pcupipeline parameter (default false).Before un-drafting / merging
6.4.2to that version (Renovate or manual) — 6.4.2 has norelease_crate.update_pcu, so the config won't validate until the pin moves. The pin is left at 6.4.2 only as a marker.Then un-draft and merge.
verbose pushrides in via #489'spcu_verbositydefault (-vv).(
yamllintclean; full orb-resolution runs once the pin points at the released toolkit version.)