feat: default pcu release prlog commit to ci-skip#1006
Open
gortavoher wants to merge 1 commit into
Open
Conversation
The release command now skips CI on its prlog update commit by default; --no-skip-ci opts back into validation. Mirrors the `pcu pr` negation mechanism but flips the default: the release work itself was validated, so the one-line post-release prlog commit need not be revalidated. Unlike `pr` (whose skip is forced by the toolkit), `release` owns this default so the skip takes effect even when the orb passes no flag — e.g. the toolkit's own release pulling unreleased pcu from main via update_pcu, which lets it observe whether the v* tag still triggers the orb publish. Effective decision computed by Release::should_skip_ci (!no_skip_ci), relying on the flags' overrides_with for last-wins. RED/GREEN. Signed-off-by: Jeremiah Russell <jerry@jrussell.ie>
Contributor
✅ Commit Signature Verification - SuccessAll commits have been verified successfully. Summary
No impersonation attempts detected. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
pcu releasenow skips CI on its prlog update commit by default. Thenegation flags are unchanged in mechanism —
--no-skip-ciopts back intovalidation,
--skip-ciis the (now redundant) explicit form, last-wins viaoverrides_with— but the default flips from validate to skip.Why a different default from
pcu prpcu prdefaults to validate and is skipped only when the toolkit forces--skip-ci. The release path runs a different command (pcu release --update-prlog), and the toolkit's own release runs on an older dogfood orbthat passes no skip flag. For the post-release prlog skip to take effect there
— and specifically so the toolkit's own release (which pulls unreleased pcu
from main via
update_pcu) produces a marker-bearing prlog commit — thedefault has to live in the
releasecommand itself. That marker on theworkspace
v*commit is what lets us observe whether the tag push stilltriggers the orb-publish pipeline.
The release work itself was already validated, so re-validating the one-line
PRLOG edit is redundant; skipping it by default matches the post-merge
update_prlogconvention.How
Release::should_skip_ci()returns!no_skip_ci(skip unless explicitlyopted out); consumed at the
--update-prlogcommit instead of the raw field.--no-skip-ciis required by orb repos whosev*tag triggers the publish(the marker must not reach the tagged commit) and by multi-crate flows that
validate once at the prlog.
RED/GREEN: the negation test now asserts default-skip via
should_skip_ci().🤖 Generated with Claude Code