feat: add configurable bottom panel for torrent details v2#1150
Open
marcinmajsc wants to merge 7 commits into
Open
feat: add configurable bottom panel for torrent details v2#1150marcinmajsc wants to merge 7 commits into
marcinmajsc wants to merge 7 commits into
Conversation
Add a persistent, resizable bottom panel to display torrent details as an alternative to the modal popup. The panel can be enabled/disabled via user settings and includes the following features: Features: - Persistent bottom panel showing torrent details (Details, Files, Peers, Trackers, MediaInfo tabs) - Vertically resizable with height persistence (200px min, viewport-200px max) - Configurable via Settings > User Interface > "Show details as bottom panel" - Single-click shows panel on desktop (when enabled) - ESC key closes panel - Mobile devices continue using modal (responsive design) - Panel background matches torrent list for visual consistency Implementation: - Add UIStore.detailsPanelHash and detailsPanelVisible state management - Add FloodSettings.UITorrentDetailsPanel and detailsPanelHeight settings - Create TorrentDetailsPanel and TorrentDetailsPanelResizeHandle components - Update modal tab components to support dual-source (panel or modal) - Add settings UI in UITab for panel configuration - Update click handlers to respect panel setting - Add CSS Grid layout for panel integration Breaking Changes: None - Default behavior shows panel (enabled by default) - Users can disable to restore original modal-only behavior - Mobile behavior unchanged (always uses modal)
…s-bottom-panel Signed-off-by: Marcin Maj <marcinmajsc@gmail.com>
Use mobx-react-lite Signed-off-by: Marcin Maj <marcinmajsc@gmail.com>
Collaborator
Contributor
Author
|
@trim21 his work has been included. This PR contains the original commits with its changes. |
Collaborator
Do you mind I wait for his reponse for a week? then I'll review your PR |
Contributor
Author
Sure 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request is based on #1004 with changes:
Screenshots
Types of changes
Related to #1004