feat(config)!: Rename CONFIG_DIR env var to LAZYDOCKER_CONFIG_DIR#807
Open
byt3m4st3r wants to merge 1 commit into
Open
feat(config)!: Rename CONFIG_DIR env var to LAZYDOCKER_CONFIG_DIR#807byt3m4st3r wants to merge 1 commit into
byt3m4st3r wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The environment variable CONFIG_DIR is misleading and suggests a variable provided by the operating system.
I would propose an explicit variable called LAZYDOCKER_CONFIG_DIR, as is done, for example, by the well-known open-source tools OpenCode and Television Fuzzy Finder.
Furthermore, this could lead to conflicts with other tools that use the same variable, and a workaround using an alias right from the beginning is not necessary.