Make OIDC provider configurable#64
Open
eekdood wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This makes the cloud API OIDC implementation provider-agnostic instead of hard-coding Google as the only issuer.
The existing Google route and legacy response fields are preserved for compatibility, but the active provider is now configured through environment variables.
Closes: #12
Changes
OIDC_ISSUEROIDC_CLIENT_IDOIDC_CLIENT_SECRETOIDC_SCOPES/oidc/loginroute while keeping/oidc/google.oidcTokenoidcClientIdoidcIssueroidcGoogleandclientIdfields for existing device/UI compatibility.returnTohandling by trimming control characters, rejecting off-origin redirects, and falling back to the app devices page.Compatibility
This intentionally does not rename database fields such as
googleId. Those names are left in place to avoid a schema migration and keep this PR focused on behavior. A later cleanup PR can rename legacy Google-specific schema/code names after the provider-agnostic flow is vetted.Testing
npm run buildnpm test/oidc/callback/devicesresponse