Support all attributes in Central Configs#670
Open
attiasas wants to merge 53 commits into
Open
Conversation
…config in new flow
attiasas
added
the
safe to test
github-actions
Bot
removed
the
safe to test
attiasas
added
the
safe to test
github-actions
Bot
removed
the
safe to test
attiasas
added
the
safe to test
eranturgeman
reviewed
May 7, 2026
eranturgeman
reviewed
May 7, 2026
eranturgeman
reviewed
May 7, 2026
eranturgeman
reviewed
May 7, 2026
eranturgeman
reviewed
May 7, 2026
eranturgeman
reviewed
May 7, 2026
eranturgeman
reviewed
May 7, 2026
eranturgeman
reviewed
May 7, 2026
eranturgeman
reviewed
May 7, 2026
eranturgeman
reviewed
May 7, 2026
| log.Debug(fmt.Sprintf("%sSkipping SCA for %s as requested by input...", logPrefix, params.ScanResults.Target)) | ||
| return false, nil | ||
| } | ||
| if params.ScanResults == nil { |
Contributor
There was a problem hiding this comment.
I see this check existed before, but I dont think it is really a possible usecase. we can leave it for safety though
| } | ||
|
|
||
| func TestPrepareSimpleJsonVulnerabilities_Technology(t *testing.T) { | ||
| testCases := []struct { |
Contributor
There was a problem hiding this comment.
maybe add another testcase with multi-rows and different technologies?
Contributor
eranturgeman
left a comment
eranturgeman
left a comment
There was a problem hiding this comment.
LGTM! see my comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(audit): config-profile scan targets, include/exclude, and xray-lib working dirsDepends on:
XRAY-135682 (bug: secrets/CA when multiple roots are passed)
XRAY-138915 (improvement: iac does not support multiple roots)
XSC - Update params in config profile jfrog-client-go#1344
Analyzer-Manager minimum version:
1.33.0Summary
Aligns audit, git audit, SCA (Xray-Lib), and JAS scanners with JFrog Platform config profiles: per-target include/exclude patterns, scanner enablement, secret validation, partial results, and custom analyzer download paths. Passes resolved include directories and exclusions into Xray-Lib instead of global ignore patterns, and refactors scan execution around an enriched
ScanTargetmodel.Changes
commands/audit/,commands/scan/,commands/git/audit/): target discovery viaGetTargetsInfo; populateScanTargetwith include/exclude and central-config modules; honor config-profile scanner toggles andallow_partial_results; wire custom releases repo for Xray-Lib plugin download.sca/bom/xrayplugin/): passIncludeDirsand per-target SCA exclusions to the plugin; removeWithTotalTargets/WithIgnorePatterns; supportWithCentralRemoteReleasesDetailsfor profile-driven dependency downloads.jas/,jas/runner/): run againstresults.ScanTarget(include roots, profile exclusions); consolidate config-profile skip logic; fix SARIF invocation working directory to reflect scan target, not analyzer-manager temp dir; per-target secret validation viaIsSecretValidationActive.utils/results/):ScanTargetgainsInclude,Exclude,Technologies[],CentralConfigModules; skippableGeneralErrors/TargetErrorsfor partial results; helpers for central-config scan requests and exclusions; expanded unit tests.utils/paths.go,utils/techutils.go): pattern handling for include/exclude during recursive scans.commands/git/audit/): fetch config profile by clone URL; hidden--use-config-profileflag (default true); validate single-module profile constraints.cli/docs/flags.go,cli/gitcommands.go): exposeWorkingDirson audit; add hiddenuse-config-profile.utils/results/conversion/,utils/results/output/): adapt to multi-technology targets and updated error shapes.go.mod,go.sum): bumpjfrog-client-goandjfrog-cli-artifactory.Notes
TechnologyonScanTargetreplaced byTechnologies[];GeneralErrorreplaced byGeneralErrors(SkippableError); JASScannerCmdadds target-basedRunwithDeprecatedRunfor legacyjfrog-apps-configmodules.path_from_root: "."(enforced inverifyConfigProfile).jfrog-apps-config.ymlis deprecated – flags, env vars, or central JFrog Platform config should be used instead.jfrog-apps-configas before.