Support WSL#523
Merged
Merged
Conversation
attiasas
added
improvement
|
@attiasas What is the estimated time of delivering this? |
Collaborator
Author
@Ahm-khd-seb Probably around next week Should finish today (and then review + releases) |
attiasas
added
new feature
orto17
reviewed
May 13, 2026
orto17
reviewed
May 13, 2026
| Path targetPath = null; | ||
| Path archivePath = null; | ||
| try { | ||
| String linuxHome = ScanUtils.getWslLinuxHome(distro); |
Contributor
There was a problem hiding this comment.
Unhandled error - No guard if getWslLinuxHome throws — object reaches inconsistent state (binaryLinuxPath null while wslDistro is set)
Collaborator
Author
There was a problem hiding this comment.
It's ok.
We have the notSupported attribute that is set and guard the shouldExecute func
| null, new NullLog(), Long.MAX_VALUE, TimeUnit.MINUTES); | ||
| Map<String, String> credentialEnv = createCredentialEnv(); | ||
| Map<String, String> wslEnv = createEnvWithCredentials(); | ||
| wslEnv.put("WSLENV", String.join(":", credentialEnv.keySet())); |
Contributor
There was a problem hiding this comment.
WSLENV credential forwarding: ensure only the intended variables are exported, not the full environment
Collaborator
Author
There was a problem hiding this comment.
we want to forward all env, similar to other tools and without WSL
orto17
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: support WSL when using the JFrog IDEA pluginSummary
This change makes the plugin behave correctly when the project lives on a Windows Subsystem for Linux (WSL) filesystem (
\\wsl$\…///wsl$/…): security scans run inside the detected distro viawsl.exe, paths are normalized across WSL UNC and IntelliJ spellings, and SARIF locations map to files the IDE can open. This depends on coordinated updates in ide-plugins-common and build-info (see below).Depends on
Merge or release order should satisfy these dependencies before this plugin change ships.
Changes
ScanBinaryExecutor: Per-executor state instead of statics; WSL branch runs the analyzer under the distro (wsl.exe), Linux roots/temp/output, credential env viaWSLENV,chmodfor extracted binary; default analyzer manager version1.31.1.ScanUtils: WSL distro parsing from UNC paths; Linux home and arch inside the distro.DescriptorPathUtils(new): WSL/IDE path equivalence,VirtualFileresolution, SARIFfile:///…→\\wsl$\{distro}\…on Windows when a distro is known.SourceCodeScannerManager: Detect WSL from Windows project base path; wire applicability and binary executors with distro when applicable.JFrogSecurityWarning/ inspections / tree / scanners: Use new path utilities so findings, annotations, and descriptor discovery align with WSL paths.build.gradle: Dependency versions aligned with the upstream PRs (including SNAPSHOTs while integrating); finalize released versions before release.Testing
DescriptorPathUtilsTest,ScanBinaryExecutorTest(and full./gradlew test/ CI).\\wsl$\<distro>\…, run scans, confirm navigation to source and stable UI/tree behavior.