Skip to content

Merged many good pull requests for you#409

Open
trishume wants to merge 10 commits into
jigish:masterfrom
trishume:master
Open

Merged many good pull requests for you#409
trishume wants to merge 10 commits into
jigish:masterfrom
trishume:master

Conversation

@trishume

@trishume trishume commented Jul 2, 2014

Copy link
Copy Markdown
Contributor

This PR is an amalgamation of the merging of many of the good pull requests that have been submitted but not merged. I've compiled and tested them and they all work together.

Anyone who wants an app package with all these changes can download one here (not signed sorry):
http://thume.net/downloads/Slate.zip

@jigish if you don't want to look at individual PRs you can just merge this one.

Creators of PRs in this one: @josh- @napcae @jpsim @mattr- @wincent @georg

trishume and others added 10 commits July 2, 2014 11:16
Including a description for how to turn on the Accessibility API for OS X 10.9 Mavericks.
Found with XCode 5's static analyis tool
This can be useful to distinguish between apps like Chrome and Chrome
Canary (which both report their name as "Google Chrome" but have bundle
identifiers `com.google.Chrome` and `com.google.Chrome.canary`
respectively).

This can be used in a `.slate.js` to do things like the following,
which is a layout that pushes Canary windows to the left half of the
screen and normal Chrome windows to the right half:

    slate.layout('my-layout', {
      'Google Chrome': {
        operations: [function(window) {
          var app = window.app();
          if (app.bundleIdentifier() === 'com.google.Chrome.canary') {
            // code to push window left
          } else {
            // code to push window right
          }
        }],
        repeat: true,
      },
    });
@p0deje

p0deje commented Jul 3, 2014

Copy link
Copy Markdown

@trishume Thanks a lot!

@sdegutis

Copy link
Copy Markdown

👍

@sdegutis

Copy link
Copy Markdown

@trishume It may also be helpful to explain which PRs you did not merge and why not.

@trishume

Copy link
Copy Markdown
Contributor Author

At this point I forget. One criteria was I only merged PRs that were complete and ready to merge. In the case of duplicates I only merged whichever one looked nicer.

I also only merged PRs which I believed would be non-controversial. If something looked like some people might disagree with it being merged (or somebody had already voiced concerns) then I didn't add it.

p0deje added a commit to p0deje/dotfiles that referenced this pull request Jul 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants