Fix sdist missing tests/__init__.py causing ImportError#356
Closed
nuglifeleoji wants to merge 1 commit intojmespath:developfrom
Closed
Fix sdist missing tests/__init__.py causing ImportError#356nuglifeleoji wants to merge 1 commit intojmespath:developfrom
nuglifeleoji wants to merge 1 commit intojmespath:developfrom
Conversation
The sdist tarball on PyPI omitted the tests/__init__.py file because
MANIFEST.in only listed top-level files (README.rst and LICENSE).
Without tests/__init__.py, importing `from tests import OrderedDict`
in test_compliance.py fails with:
ImportError: cannot import name 'OrderedDict' from 'tests' (unknown location)
Add `recursive-include tests *` to MANIFEST.in so that all files under
the tests/ directory are included in the source distribution.
Fixes #341
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem (fixes #341)
The sdist published on PyPI omits
tests/__init__.pybecauseMANIFEST.inonly includes top-level files. Without this file, running the test suite from an unpacked sdist fails with:This happens because
test_compliance.pydoesfrom tests import OrderedDict, which requiresteststo be a proper package (i.e., have an__init__.py).Fix
Add
recursive-include tests *toMANIFEST.inso that all files under thetests/directory are included in source distributions.Verification
Made with Cursor