Conditionally set the CSS "top" property.#144
Open
Kravimir wants to merge 1 commit into
Open
Conversation
The "top" property was being reset to 0 for the ".tableFloatingHeaderOriginal" element so many of the times that toggleHeaders() was called and then being set again via setPositionValues(). Now the element doesn't "jump" unexpectedly.
kliput
reviewed
May 29, 2018
| 'z-index': base.options.zIndex | ||
| }); | ||
| }; | ||
| if(base.$originalHeader.get(0).styles.top=='') |
There was a problem hiding this comment.
HTMLElement has no styles property:
https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement - instead style should be used.
Did you managed to get this work on some browser? For me, on Chromium it doesn't work.
Edit: Tested changing to style and it works perfectly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "top" property was being reset to 0 for the ".tableFloatingHeaderOriginal" element so many of the times that toggleHeaders() was called and then being set again via setPositionValues(). Now the element doesn't "jump" unexpectedly.