This repository was archived by the owner on Apr 23, 2026. It is now read-only.
Performance fixes for Scala code generation#22
Merged
Conversation
- Cache `SwiftNode.toString` to avoid repeated reflection overhead - Replace generated AST node wrappers with direct pattern matching (~2800 lines removed) - Replace O(n) sequential if-chain in `createSwiftNode` with `HashMap` dispatch for both node types and token kinds - Replace repeated `.arr.toList.find()` child accessors with a cached `_childrenMap` (`Map[String, Value]`) built once per node, eliminating linear scans and intermediate List allocations on every property access - Replace Try-based range accessors (`startOffset`, `endLine`, etc.) with safe `obj.get` lookups, avoiding exception construction and fillInStackTrace overhead when fields are absent
max-leuthaeuser
force-pushed
the
max/perf-fixes
branch
from
8602364 to
87a97a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SwiftNode.toStringto avoid repeated reflection overheadcreateSwiftNodewithHashMapdispatch for both node types and token kinds.arr.toList.find()child accessors with a cached_childrenMap(Map[String, Value]) built once per node, eliminating linear scans and intermediate List allocations on every property accessstartOffset,endLine, etc.) with safeobj.getlookups, avoiding exception construction and fillInStackTrace overhead when fields are absent