Adding support for shallow hashes#2
Open
johnlevidy wants to merge 2 commits into
Open
Conversation
jordanp1127
reviewed
Feb 5, 2025
| l = [] | ||
| for name, type_ in root.fields.items(): | ||
| if isinstance(type_, mir.DetachedVariant) and type_.is_hash_tag: | ||
| l.append(f"{name}=HashVariant") |
There was a problem hiding this comment.
This crucially prevents recursion and keeps the hash variants shallow?
Owner
Author
There was a problem hiding this comment.
it's still important to include the type, but that's exactly right: "i dont need to include the inner types in the hash b/c access is protected by the hash"
jordanp1127
reviewed
Feb 5, 2025
| return visitor.visit_variant_ref(self) | ||
|
|
||
| @dataclasses.dataclass(frozen=True) | ||
| class HashVariantRef(VariantRef): |
There was a problem hiding this comment.
Is the purpose of this so that we can differentiate between the two?
Owner
Author
There was a problem hiding this comment.
yeah, it's either this or a field on variantref
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.