Skippablehash#3
Open
johnlevidy wants to merge 5 commits into
Open
Conversation
…ng to incorporate skippability in a nullable length type
Owner
Author
|
|
Owner
Author
|
|
Owner
Author
|
all parsing activity like getting a vector view above aren't returning a vector view but a parse result. the parse result always has a tail. we should be able to piggy back off that of that idea, broadly, to build skippability. essentially, with little change we can have an HV that "fails to parse" but doesn't return error and correctly advances tail in the returned parseresult |
Owner
Author
|
Parse result that gets carried over for tail can also hold offset_good or similar |
jordanp1127
reviewed
Feb 6, 2025
| @@ -0,0 +1,15 @@ | |||
| from tako.core.types import * | |||
|
|
|||
There was a problem hiding this comment.
How do you come up with this stuff 😆
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.