Skip to content

Decouple TLS from transport#212

Draft
mrabine wants to merge 9 commits into
mainfrom
201-decouple-tls-from-transport-using-decorator-pattern
Draft

Decouple TLS from transport#212
mrabine wants to merge 9 commits into
mainfrom
201-decouple-tls-from-transport-using-decorator-pattern

Conversation

@mrabine

@mrabine mrabine commented May 29, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@mrabine mrabine linked an issue May 29, 2026 that may be closed by this pull request
@codacy-production

codacy-production Bot commented May 29, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 1659 complexity · 599 duplication

Metric Results
Complexity 1659
Duplication 599

View in Codacy

🟢 Coverage 92.03% diff coverage · +0.13% coverage variation

Metric Results
Coverage variation +0.13% coverage variation
Diff coverage 92.03% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (84fef3a) Report Missing Report Missing Report Missing
Head commit (7ffe350) 11199 (-774) 10846 (-734) 96.85% (+0.13%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#212) 1229 1131 92.03%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

1 Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@coveralls

coveralls commented Jun 21, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 27966021486

Coverage increased (+0.1%) to 96.848%

Details

  • Coverage increased (+0.1%) from the base build.
  • Patch coverage: 98 uncovered changes across 9 files (1131 of 1229 lines covered, 92.03%).
  • 6 coverage regressions across 2 files.

Uncovered Changes

File Changed Covered %
crypto/include/join/tls.hpp 333 295 88.59%
core/include/join/datagram_socket.hpp 112 97 86.61%
fabric/include/join/resolver.hpp 100 85 85.0%
crypto/include/join/dtls_wrapper.hpp 39 26 66.67%
core/include/join/stream_socket.hpp 159 150 94.34%
core/include/join/socket_stream.hpp 60 57 95.0%
crypto/include/join/tls_stream.hpp 30 28 93.33%
crypto/src/tls_context.cpp 97 95 97.94%
core/include/join/socket.hpp 101 100 99.01%
Total (21 files) 1229 1131 92.03%

Coverage Regressions

6 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
fabric/include/join/resolver.hpp 5 89.38%
data/include/join/streambuf.hpp 1 95.65%

Coverage Stats

Coverage Status
Relevant Lines: 11199
Covered Lines: 10846
Line Coverage: 96.85%
Coverage Strength: 115654.85 hits per line

💛 - Coveralls

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.82814% with 97 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.83%. Comparing base (84fef3a) to head (7ffe350).

Files with missing lines Patch % Lines
crypto/include/join/tls.hpp 88.54% 37 Missing ⚠️
core/include/join/datagram_socket.hpp 86.11% 15 Missing ⚠️
fabric/include/join/resolver.hpp 84.53% 15 Missing ⚠️
crypto/include/join/dtls_wrapper.hpp 65.78% 13 Missing ⚠️
core/include/join/stream_socket.hpp 94.19% 9 Missing ⚠️
core/include/join/socket_stream.hpp 94.82% 3 Missing ⚠️
crypto/include/join/tls_stream.hpp 92.30% 2 Missing ⚠️
crypto/src/tls_context.cpp 97.87% 2 Missing ⚠️
core/include/join/socket.hpp 99.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #212      +/-   ##
==========================================
+ Coverage   96.72%   96.83%   +0.11%     
==========================================
  Files          96      107      +11     
  Lines       11227    10502     -725     
==========================================
- Hits        10859    10170     -689     
+ Misses        368      332      -36     
Flag Coverage Δ
unittests 96.83% <91.82%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decouple TLS from Transport using Decorator Pattern

2 participants