Repository navigation
fix: restore scroll progress bar and stop mobile horizontal overflow - #62
Merged
Merged
Conversation
- Use animation longhands for the scroll-driven progress bar; the CSS minifier folded shorthand + animation-timeline into an `animation` shorthand containing scroll(), which browsers reject, so the bar never filled - Clip horizontal overflow on html/body so the decorative hero scanline no longer makes the page scroll sideways on narrow screens Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 32 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found during post-merge verification of #61 on the live site.
animation+animation-timelineinto a singleanimation: linear both scroll-progress scroll(root)shorthand. Browsers reject a timeline inside theanimationshorthand, so the declaration was dropped andanimation-namecomputed tonone. Supporting browsers also skip the JS fallback, so the bar stayed at 0. Switching to longhands survives minification..scanlinebleeds 12% past the hero, making the page 25px wider than a 390px viewport.overflow-x: cliponhtml, bodystops it;clipdoesn't create a scroll container, so positioning is unaffected.Verification (local
astro previewin Chromium)scaleX0 → 0.25 → 0.50 → ~1.0 (live site before the fix: 0 at every position)scrollWidth384 ≤ 390, horizontalscrollXstays 0 (before: 415 and scrollable)bun run lint: 0 errors / 0 warnings / 0 hints;bun run buildpassesNoted, not changed
The
.section-rulerposition: stickyhas never taken effect (itsRevealwrapper is exactly the label's height, the same as in the old React version). Left for the upcoming redesign.🤖 Generated with Claude Code