[5.4] Add missing page parameter to contentEventArguments - Article Module#47476
Open
LadySolveig wants to merge 1 commit intojoomla:5.4-devfrom
Open
[5.4] Add missing page parameter to contentEventArguments - Article Module#47476LadySolveig wants to merge 1 commit intojoomla:5.4-devfrom
LadySolveig wants to merge 1 commit intojoomla:5.4-devfrom
Conversation
|
I have tested this item ✅ successfully on a7fe11e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47476. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request resolves # .
Summary of Changes
The AI took the fun approach here #47467 when generating the test plugin by pointing out that the
pageargument is missing, resulting in inconsistent test results for the legacy modules compared to the new article module.This would work at the moment in the new Article Module, but nowhere else as all others have an offset or 0 default.
As it is more consistent with the rest of the codebase to include the
pageargument and give it value0instead ofnullas we do everywhere else, here is the PR for that.Testing Instructions
Code Review
Actual result BEFORE applying this Pull Request
Unconsistent
Expected result AFTER applying this Pull Request
Consistent
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed