Skip to content

[5.4] DRAFT Remove image fallback in HTMLHelper.php#47477

Draft
chinmayi-sudo wants to merge 2 commits intojoomla:5.4-devfrom
chinmayi-sudo:patch-1
Draft

[5.4] DRAFT Remove image fallback in HTMLHelper.php#47477
chinmayi-sudo wants to merge 2 commits intojoomla:5.4-devfrom
chinmayi-sudo:patch-1

Conversation

@chinmayi-sudo
Copy link
Copy Markdown

@chinmayi-sudo chinmayi-sudo commented Mar 26, 2026

Summary of Changes

This PR removes the unused image fallback from "HTMLHelper.php".

Previously, when "$text" was empty, an image fallback ("tooltip.png") was generated using "static::image()". This fallback is no longer required as the image is deprecated and not used in the current codebase.

Testing Instructions

  1. Open a Joomla page where tooltips are used
  2. Trigger a tooltip without text
  3. Check:
    • No broken image is displayed
    • Tooltip still works correctly
    • No UI issues appear

Expected result

  • No fallback image should appear
  • UI should remain unaffected

Actual result

  • Fallback image logic removed successfully

Documentation Changes Required

No

AI Policy

I confirm that this pull request follows Joomla's AI contribution guidelines.
#47477

Removed image fallback for tooltip and set text to empty.
@exlemor
Copy link
Copy Markdown

exlemor commented Mar 26, 2026

@chinmayi-sudo Please use our Pull Request template and do not remove the pre-defined headings but fill in the missing information instead. This includes:

  • Acknowledgement of the AI policy
  • Don't remove or rename Pre-Defined Section Headers
  • More specific step-by-step Testing instructions so testers can help test your fix.

Thank you! We appreciate your contribution to Joomla!

If you don't do this within a reasonable time of 2-3 weeks, this PR will be closed.

@Fedik
Copy link
Copy Markdown
Member

Fedik commented Mar 26, 2026

What if someone use own image?
This PR breaks such possibility.

@chinmayi-sudo
Copy link
Copy Markdown
Author

Thank you for the feedback. I have updated the PR description as per the template.

@brianteeman
Copy link
Copy Markdown
Contributor

As this code is not used in the core of joomla the test instructions are not complete

@brianteeman
Copy link
Copy Markdown
Contributor

the code is obviously wrong

@chinmayi-sudo
Copy link
Copy Markdown
Author

@brianteeman Thank you for the feedback. I understand that the change may not be correct and the testing instructions are insufficient. I will review the issue again and update the PR accordingly.

@brianteeman
Copy link
Copy Markdown
Contributor

It is expected that at a very minimum BEFORE you start that you can replicate the problem. Until you can do that then you are not able to verify that your proposed code will fix something.

@muhme
Copy link
Copy Markdown
Contributor

muhme commented Mar 31, 2026

@chinmayi-sudo Thank you for your contribution!

As already stated please use the standard PR template to format the description. It is much easier to find the information given with each PR on the same place in the the same format.

We will set this PR to DRAFT for now. Please feel free to update it within the next two weeks and mark it as ready for review again — otherwise, we may need to close it.

Additionally, the continuous integration currently reports PHP code style issues that need to be addressed. Alle CI checks needs to be passed before to mark the PR as ready for review.

@muhme muhme marked this pull request as draft March 31, 2026 07:20
@muhme muhme changed the title Fix: Remove image fallback in HTMLHelper.php [5.4] DRAFT Remove image fallback in HTMLHelper.php Mar 31, 2026
@chinmayi-sudo
Copy link
Copy Markdown
Author

@chinmayi-sudo Thank you for your contribution!

As already stated please use the standard PR template to format the description. It is much easier to find the information given with each PR on the same place in the the same format.

We will set this PR to DRAFT for now. Please feel free to update it within the next two weeks and mark it as ready for review again — otherwise, we may need to close it.

Additionally, the continuous integration currently reports PHP code style issues that need to be addressed. Alle CI checks needs to be passed before to mark the PR as ready for review.

Sure sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants