Enhance com_menus filters to support URL-based query parameters#47485
Enhance com_menus filters to support URL-based query parameters#47485bharath110520 wants to merge 1 commit intojoomla:5.4-devfrom
Conversation
@bharath110520 Please read: #47215 |
|
As you yourself have already mentioned here #47445 (comment), this PR is, if anything, an enhancement. Please take another close look at whether this is consistent with the rest of the codebase and check whether this behavior actually occurs in other places as well and is expected here. Thank you for your time and your try. |
|
This is obviously wrong |
|
Please read #47215 carefully, you are missing: |
|
Thanks for the clarification. I’ve updated the PR and added the AI usage declaration. |
Thank you for the feedback. I understand that implementing this via an inline script in the template is not aligned with Joomla’s architecture. I explored this approach to validate the behavior, but I see that a proper solution would require changes at the core searchtools or framework level to maintain consistency. I will take some time to better understand the existing implementation and architectural patterns before attempting a revised approach. Appreciate your guidance. |
|
|
@bharath-phenix Thank you very much for your contribution! We have closed the issue with "In Joomla administrator lists (such as Menus, Articles, etc.), filter values are typically stored in the user session rather than in the URL. This behaviour is therefore expected and not considered a bug." We will go ahead and close this PR. |
Pull Request resolves #47445.
I read the Generative AI policy and my contribution is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Enhances the
com_menusadministrator view to support URL-based filter parameters.Currently, filter interactions rely on POST requests and session state, so filter values are not reflected in the URL. This change updates filter handling to use URL query parameters, improving usability and enabling shareable filtered views.
Key improvements include:
filter[search])Testing Instructions
Go to Administrator → Menus → Manage
Change filters such as:
Verify that:
Test toolbar actions:
Confirm that these actions still work correctly using POST requests.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
No documentation changes for guide.joomla.org needed
No documentation changes for manual.joomla.org needed
AI usage
I have read the Generative AI policy.
This contribution was created with assistance from AI tools, but I have fully reviewed, tested, and validated the code.
I confirm that: